[
https://issues.apache.org/jira/browse/BOOKKEEPER-176?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13218991#comment-13218991
]
Flavio Junqueira commented on BOOKKEEPER-176:
---------------------------------------------
It looks good, Ivan. I have a couple of questions, one not directly related to
this patch:
# I was wondering if it is clean to pass a zk reference to a constructor and
have the constructor creating it when the reference is null. We can document
it, but this is not exactly the behavior I would expect. In any case, I don't
feel strongly about a change here, but I wanted to raise the point.
# There is a todo saying "handle session disconnects and expires". I noticed it
was there already, and it made me wonder what happens if a client loses its
session. Don't we try to establish a new session? I don't think we care about
the order aspect of sessions here, so I think we need to create a new session
if the initial one is gone, no?
> HierarchicalBookieFailureTest Hung
> ----------------------------------
>
> Key: BOOKKEEPER-176
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-176
> Project: Bookkeeper
> Issue Type: Bug
> Reporter: Flavio Junqueira
> Assignee: Ivan Kelly
> Fix For: 4.1.0
>
> Attachments: BOOKKEEPER-176.diff,
> HierarchicalBookieFailureTest.jstack.out
>
>
> See jstack attachment.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
