[
https://issues.apache.org/jira/browse/BOOKKEEPER-175?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13233267#comment-13233267
]
[email protected] commented on BOOKKEEPER-175:
----------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4405/#review6113
-----------------------------------------------------------
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/Bookie.java
<https://reviews.apache.org/r/4405/#comment13142>
do you consider moving masterKeyCache into ledgerCache? it seems that would
be more clear.
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/Bookie.java
<https://reviews.apache.org/r/4405/#comment13143>
it seems that there is a reference counting in ledger handle before. but
after refactoring, you remove it. so is it OK?
- Sijie
On 2012-03-19 11:43:51, Ivan Kelly wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/4405/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-03-19 11:43:51)
bq.
bq.
bq. Review request for bookkeeper.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. Patch creates LedgerCache interface, and LedgerCacheImpl, which implements
the interface. LedgerCacheImpl's contains what LedgerCache did before the
change. LedgerDescriptor uses LedgerCacheImpl directly now, which is ugly, but
its only temporary as BOOKKEEPER-175 will fix LedgerDescriptors.
bq.
bq.
bq. This addresses bug BOOKKEEPER-175.
bq. https://issues.apache.org/jira/browse/BOOKKEEPER-175
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/Bookie.java
6e47c08
bq.
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/HandleFactory.java
PRE-CREATION
bq.
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/HandleFactoryImpl.java
PRE-CREATION
bq.
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/LedgerDescriptor.java
87a1e66
bq.
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/LedgerDescriptorImpl.java
PRE-CREATION
bq.
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/LedgerDescriptorReadOnlyImpl.java
PRE-CREATION
bq.
bq. Diff: https://reviews.apache.org/r/4405/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq.
bq. Thanks,
bq.
bq. Ivan
bq.
bq.
> Bookie code is very coupled
> ---------------------------
>
> Key: BOOKKEEPER-175
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-175
> Project: Bookkeeper
> Issue Type: Improvement
> Reporter: Ivan Kelly
> Assignee: Ivan Kelly
> Fix For: 4.1.0
>
> Attachments: BOOKKEEPER-175.diff
>
>
> Bookie owns EntryLogger, LedgerCache, LedgerDescriptors which all depend on
> each other in strange ways. Sometimes we access the ledgerCache directly,
> sometimes through LedgerDescriptors. etc, etc. It's messy and there's no
> hierarchy.
> I propose that we refactor Bookie to only contain the EntryLogger and
> journalling code (this should be factored at some stage also). The
> EntryLogger can then own the ledgerCache and the LedgerDescriptors, and then
> we would how have to have the entanglement as observed on BOOKKEEPER-160.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
