[ 
https://issues.apache.org/jira/browse/BOOKKEEPER-175?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13233873#comment-13233873
 ] 

Hudson commented on BOOKKEEPER-175:
-----------------------------------

Integrated in bookkeeper-trunk #419 (See 
[https://builds.apache.org/job/bookkeeper-trunk/419/])
    BOOKKEEPER-175: Bookie code is very coupled (ivank) (Revision 1302870)

     Result = ABORTED
ivank : 
Files : 
* /zookeeper/bookkeeper/trunk/CHANGES.txt
* 
/zookeeper/bookkeeper/trunk/bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/Bookie.java
* 
/zookeeper/bookkeeper/trunk/bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/HandleFactory.java
* 
/zookeeper/bookkeeper/trunk/bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/HandleFactoryImpl.java
* 
/zookeeper/bookkeeper/trunk/bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/LedgerDescriptor.java
* 
/zookeeper/bookkeeper/trunk/bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/LedgerDescriptorImpl.java
* 
/zookeeper/bookkeeper/trunk/bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/LedgerDescriptorReadOnlyImpl.java

                
> Bookie code is very coupled
> ---------------------------
>
>                 Key: BOOKKEEPER-175
>                 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-175
>             Project: Bookkeeper
>          Issue Type: Improvement
>            Reporter: Ivan Kelly
>            Assignee: Ivan Kelly
>             Fix For: 4.1.0
>
>         Attachments: BOOKKEEPER-175.diff
>
>
> Bookie owns EntryLogger, LedgerCache, LedgerDescriptors which all depend on 
> each other in strange ways. Sometimes we access the ledgerCache directly, 
> sometimes through LedgerDescriptors. etc, etc. It's messy and there's no 
> hierarchy.
> I propose that we refactor Bookie to only contain the EntryLogger and 
> journalling code (this should be factored at some stage also). The 
> EntryLogger can then own the ledgerCache and the LedgerDescriptors, and then 
> we would how have to have the entanglement as observed on BOOKKEEPER-160.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to