-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4481/
-----------------------------------------------------------
(Updated 2012-03-29 05:27:14.643196)
Review request for bookkeeper.
Changes
-------
improve patch to use latch instead of time.
Summary
-------
create a snapshot of bookie active ledgers, and then fetch the list of
zookeeper metadata, then it is safe to do garbage collection.
This addresses bug BOOKKEEPER-193.
https://issues.apache.org/jira/browse/BOOKKEEPER-193
Diffs (updated)
-----
bookkeeper-server/src/main/java/org/apache/bookkeeper/meta/SnapshotMap.java
PRE-CREATION
bookkeeper-server/src/main/java/org/apache/bookkeeper/meta/FlatLedgerManager.java
100cdad
bookkeeper-server/src/main/java/org/apache/bookkeeper/meta/HierarchicalLedgerManager.java
169c906
bookkeeper-server/src/test/java/org/apache/bookkeeper/meta/GcLedgersTest.java
PRE-CREATION
bookkeeper-server/src/test/java/org/apache/bookkeeper/meta/LedgerManagerTestCase.java
PRE-CREATION
Diff: https://reviews.apache.org/r/4481/diff
Testing
-------
Thanks,
Sijie