[
https://issues.apache.org/jira/browse/BOOKKEEPER-234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13270294#comment-13270294
]
Sijie Guo commented on BOOKKEEPER-234:
--------------------------------------
lgtm +1
> EntryLogger will throw NPE, if any dir does not exist or IO Errors.
> -------------------------------------------------------------------
>
> Key: BOOKKEEPER-234
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-234
> Project: Bookkeeper
> Issue Type: Bug
> Components: bookkeeper-server
> Affects Versions: 4.1.0
> Reporter: Uma Maheswara Rao G
> Assignee: Uma Maheswara Rao G
> Attachments: BOOKKEEPER-234.patch
>
>
> I think, Entry log should check the exitance of directories, before going to
> get the last Log entries. Because, listFiles will retunr null on non existant
> directories or any IO Errors. We have to add the check for directory
> existnace check and null checks in side getLastLogID api in EntryLogger.
> We may need to handle in LedgerCacheImpl also.
> Do we need to add them in bad disks list? and others will refer this list
> before they use the dirs.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
