[
https://issues.apache.org/jira/browse/BOOKKEEPER-234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13270529#comment-13270529
]
Uma Maheswara Rao G commented on BOOKKEEPER-234:
------------------------------------------------
Yep, Ivan, I have seen it in checkEnvironment call. If directory does not exist
then it is creating it.
Yes, In my testing environment it happened on the the startup of BK,
unfortunately dirs have been cleaned(through some test scripts) . I am assuming
that, after this step(checkEnvironment) only that might have happend. So, I
directly verified that EntryLogger code and found that peice for NPE
possibility. Do we need to throw the exception if we meet that situation, as we
may not have Version files and all right? Now I can see this is very very rare
case. Do we need to handle it?
> EntryLogger will throw NPE, if any dir does not exist or IO Errors.
> -------------------------------------------------------------------
>
> Key: BOOKKEEPER-234
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-234
> Project: Bookkeeper
> Issue Type: Bug
> Components: bookkeeper-server
> Affects Versions: 4.1.0
> Reporter: Uma Maheswara Rao G
> Assignee: Uma Maheswara Rao G
> Attachments: BOOKKEEPER-234.patch
>
>
> I think, Entry log should check the exitance of directories, before going to
> get the last Log entries. Because, listFiles will retunr null on non existant
> directories or any IO Errors. We have to add the check for directory
> existnace check and null checks in side getLastLogID api in EntryLogger.
> We may need to handle in LedgerCacheImpl also.
> Do we need to add them in bad disks list? and others will refer this list
> before they use the dirs.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
