[ 
https://issues.apache.org/jira/browse/BOOKKEEPER-256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13273785#comment-13273785
 ] 

Aniruddha commented on BOOKKEEPER-256:
--------------------------------------

I have updated the patch to address Hyun's comments.
1) Yes, seems like I had attached the wrong patch file. This is fixed. 
2) This should probably go in a new ticket. 
3) Changed this, I was under the impression that Message.newBuilder modified 
the argument. 
4) Done. 
5) Agreed. 
                
> Update remote component sequence IDs only for messages from the source region
> -----------------------------------------------------------------------------
>
>                 Key: BOOKKEEPER-256
>                 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-256
>             Project: Bookkeeper
>          Issue Type: Improvement
>          Components: hedwig-server
>    Affects Versions: 4.1.0
>            Reporter: Aniruddha
>            Assignee: Aniruddha
>            Priority: Minor
>             Fix For: 4.1.0
>
>         Attachments: BK-256.patch
>
>
> In the current setup, remote components for a message being persisted don't 
> give any meaningful information about the number of messages the hub has 
> received for that topic from other regions. The provided patch fixes this by 
> updating the remote component of the locally persisted message for a region X 
> only if the message received by the RegionManager originates from region X. 
> Edit - You can take a look at the discussion at 
> http://mail-archives.apache.org/mod_mbox/zookeeper-bookkeeper-dev/201205.mbox/%3cCAOLhyDTEm5=p8emd8xmvcy_6ktb40rqx6dwwy50arbaebdg...@mail.gmail.com%3e
>  for context.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to