[
https://issues.apache.org/jira/browse/BOOKKEEPER-256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13273793#comment-13273793
]
Sijie Guo commented on BOOKKEEPER-256:
--------------------------------------
@Aniruddha, thanks for clarification.
> The order of the Message sequence IDs would not matter if we used
> takeRegionMaximum, but with would matter when used with the new code.
yeah, ur right.
>
How about the proposal in my previous comment? We remove the line in region
manager and improve takeRegionSpecificManager as I suggested.
>From you new patch, the message would be build twice. once in region manager,
>then in persistence manager. As what I suggested, we don't need to build a new
>message in region manager, which just propagate seq id to remote components
>list. we could avoid it by building it when takeRegionSpecificMaxmimum, right?
How is your opinion?
> Update remote component sequence IDs only for messages from the source region
> -----------------------------------------------------------------------------
>
> Key: BOOKKEEPER-256
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-256
> Project: Bookkeeper
> Issue Type: Improvement
> Components: hedwig-server
> Affects Versions: 4.1.0
> Reporter: Aniruddha
> Assignee: Aniruddha
> Priority: Minor
> Fix For: 4.1.0
>
> Attachments: BK-256.patch
>
>
> In the current setup, remote components for a message being persisted don't
> give any meaningful information about the number of messages the hub has
> received for that topic from other regions. The provided patch fixes this by
> updating the remote component of the locally persisted message for a region X
> only if the message received by the RegionManager originates from region X.
> Edit - You can take a look at the discussion at
> http://mail-archives.apache.org/mod_mbox/zookeeper-bookkeeper-dev/201205.mbox/%3cCAOLhyDTEm5=p8emd8xmvcy_6ktb40rqx6dwwy50arbaebdg...@mail.gmail.com%3e
> for context.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
