[ 
https://issues.apache.org/jira/browse/BOOKKEEPER-263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13277576#comment-13277576
 ] 

Sijie Guo commented on BOOKKEEPER-263:
--------------------------------------

thanks Aniruddha. the patch seems good. just one comment, sees that 
AVAILABLE_NODE spreads over several files. could we consider moving it to a 
common place (which could be shared by client and server), such as 
AbstractConfiguration to have a method getAvailableBookiesPath(), which is 
similar what Hedwig did in ServerConfiguration to manage its znode path.
                
> ZK ledgers root path is hard coded
> ----------------------------------
>
>                 Key: BOOKKEEPER-263
>                 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-263
>             Project: Bookkeeper
>          Issue Type: Bug
>          Components: bookkeeper-client, bookkeeper-server
>    Affects Versions: 4.1.0
>            Reporter: Aniruddha
>            Assignee: Aniruddha
>             Fix For: 4.1.0
>
>         Attachments: BK-263.patch
>
>
> Currently the ZK ledger root path is not picked up from the config file (It 
> is hardcoded). This patch fixes this. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to