[
https://issues.apache.org/jira/browse/BOOKKEEPER-263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13278503#comment-13278503
]
Sijie Guo commented on BOOKKEEPER-263:
--------------------------------------
Thanks Aniruddha for quick response.
sorry that I don't explain it more clearly. it would be better to have a method
#getZkAvailableBookiesPath().
so user doesn't need to write code as below
{code}
this.bookieRegistrationPath = conf.getZkLedgersRootPath() + "/" +
conf.getBookiesAvailableNode();
{code}
instead, they could write code as
{code}
this.bookieRegistrationPath = conf.getZkAvailableBookiesPath();
{code}
in AbstractionConfiguration, 'available' could be defined as a constant value,
and do string concatenation in method #getZkAvailableBookiesPath().
{code}
static final String AVAILABLE_ZNODE = 'available';
public String getZkAvailableBookiesPath() {
return getZkLedgersRootPath() + "/" + AVAILABLE_ZNODE;
}
{code}
seems it could make the code clearer. How is your opinion?
> ZK ledgers root path is hard coded
> ----------------------------------
>
> Key: BOOKKEEPER-263
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-263
> Project: Bookkeeper
> Issue Type: Bug
> Components: bookkeeper-client, bookkeeper-server
> Affects Versions: 4.1.0
> Reporter: Aniruddha
> Assignee: Aniruddha
> Fix For: 4.1.0
>
> Attachments: BK-263-v1.patch, BK-263.patch
>
>
> Currently the ZK ledger root path is not picked up from the config file (It
> is hardcoded). This patch fixes this.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
