[ 
https://issues.apache.org/jira/browse/BOOKKEEPER-203?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13395481#comment-13395481
 ] 

Ivan Kelly commented on BOOKKEEPER-203:
---------------------------------------

{code}
MultiLedgerManagerBaseTestCase is used to test different digest type and ledger 
manager, which gets rid of adding Hierarchical prefixed test cases.

MultiLedgerManagerTestCase is used to test different ledger manager.
{code}
So MultiLedgerManagerBaseTestCase is really a superset of 
MultiLedgerManagerTestCase. I don't see any harm in just using 
MultiLedgerManagerBaseTestCase for all. The reason I wrote some test cases 
which didn't use the BaseTestCase, was because with Parameterized junit tests, 
it's not possible to run individual tests (i.e. mvn test 
-Dtest=TestFencing#testBasicFencing), which I found annoying. However, if the 
test is going to use a Parameterized junit test in any case, we should just run 
everything.
                
> improve ledger manager interface to remove zookeeper dependency on metadata 
> operations.
> ---------------------------------------------------------------------------------------
>
>                 Key: BOOKKEEPER-203
>                 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-203
>             Project: Bookkeeper
>          Issue Type: Sub-task
>          Components: bookkeeper-client, bookkeeper-server
>            Reporter: Sijie Guo
>            Assignee: Sijie Guo
>             Fix For: 4.2.0
>
>         Attachments: BOOKKEEPER-203.diff, BOOKKEEPER-203.diff_v2, 
> BOOKKEEPER-203.diff_v3, BOOKKEEPER-203.diff_v4, BOOKKEEPER-203.diff_v5
>
>
> we need to improve ledger manager interface to remove zookeeper dependency on 
> metadata operations, so it is easy for us to implement a MetaStore based 
> ledger manager.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to