[ 
https://issues.apache.org/jira/browse/BOOKKEEPER-203?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13395766#comment-13395766
 ] 

Sijie Guo commented on BOOKKEEPER-203:
--------------------------------------

@Ivan,

{code}
HierarchicalAsyncLedgerOpsTest -> AsyncLedgerOpsTest (BaseTestCase)
HierarchicalBookieReadWriteTest -> BookieReadWriteTest (BaseTestCase)
HierarchicalBookieFailureTest -> BookieFailureTest (BaseTestCase)
HierarchicalBookieRecoveryTest -> BookieRecoveryTest (BaseTestCase)
HierarchicalLedgerDeleteTest -> LedgerDeleteTest (BookKeeperClusterTestCase)
{code}

MultiLedgerManagerBaseTestCase & MultiLedgerManagerTestCase are used to remove 
HierarchicalxxxTests to let them run as parameterized tests. 

{quote}
 So MultiLedgerManagerBaseTestCase is really a superset of 
MultiLedgerManagerTestCase. I don't see any harm in just using 
MultiLedgerManagerBaseTestCase for all.
{quote}

If everything is run as MultiLedgerManagerBaseTestCase, it would take a long 
time to run. For example, LedgerDeleteTest just tests ledger deletion 
functionality. so we don't need to parameterize the test to run with different 
digest type. But we have to run with different ledger managers because deletion 
is related to gc implementation in different ledger managers.





                
> improve ledger manager interface to remove zookeeper dependency on metadata 
> operations.
> ---------------------------------------------------------------------------------------
>
>                 Key: BOOKKEEPER-203
>                 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-203
>             Project: Bookkeeper
>          Issue Type: Sub-task
>          Components: bookkeeper-client, bookkeeper-server
>            Reporter: Sijie Guo
>            Assignee: Sijie Guo
>             Fix For: 4.2.0
>
>         Attachments: BOOKKEEPER-203.diff, BOOKKEEPER-203.diff_v2, 
> BOOKKEEPER-203.diff_v3, BOOKKEEPER-203.diff_v4, BOOKKEEPER-203.diff_v5
>
>
> we need to improve ledger manager interface to remove zookeeper dependency on 
> metadata operations, so it is easy for us to implement a MetaStore based 
> ledger manager.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to