[ 
https://issues.apache.org/jira/browse/BOOKKEEPER-304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13398408#comment-13398408
 ] 

Uma Maheswara Rao G commented on BOOKKEEPER-304:
------------------------------------------------

Yes, there will be a cycle. BK server will depend on auditor package to start 
the auditing service. Auditor Package will depend on some of BK sever exposed 
packages like core interface LedgerManager..etc.

To avoid this cycle, can we have some kind of ServicePlugins.

BK server lifecycle will start, stop this plugins. Presently there is only one 
service i.e Auditing service.

Some similar pattern from DN:

{code}
private void startPlugins(Configuration conf) {
    plugins = conf.getInstances(DFS_DATANODE_PLUGINS_KEY, ServicePlugin.class);
    for (ServicePlugin p: plugins) {
      try {
        p.start(this);
        LOG.info("Started plug-in " + p);
      } catch (Throwable t) {
        LOG.warn("ServicePlugin " + p + " could not be started", t);
      }
    }
  }{code}

Thoughts?
                
> Prepare bookie vs ledgers cache and will be used by the Auditor
> ---------------------------------------------------------------
>
>                 Key: BOOKKEEPER-304
>                 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-304
>             Project: Bookkeeper
>          Issue Type: Sub-task
>          Components: bookkeeper-server
>            Reporter: Rakesh R
>            Assignee: Rakesh R
>             Fix For: 4.2.0
>
>         Attachments: BOOKKEEPER-304.1.patch
>
>
> This JIRA discusses how to build bookie -> ledgers cache and this will be 
> used by the Auditor to publish the suspected ledgers of failed bookies.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to