[
https://issues.apache.org/jira/browse/BOOKKEEPER-317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13401235#comment-13401235
]
Flavio Junqueira commented on BOOKKEEPER-317:
---------------------------------------------
A few comments on the patch, Ivan:
# It might be a good idea to follow a structure similar to BKException with a
create method and a Code interface. One reason for having that list of codes is
to enable rc values for callbacks. Do we have such callbacks for replication?
# There is a typo in the javadoc statement for CompatException: Compatability
-> Compatibility
# I'd rather spell it out and name the exception CompatibilityException.
> Exceptions for replication
> --------------------------
>
> Key: BOOKKEEPER-317
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-317
> Project: Bookkeeper
> Issue Type: Sub-task
> Reporter: Ivan Kelly
> Assignee: Ivan Kelly
> Fix For: 4.2.0
>
> Attachments: BOOKKEEPER-317.diff
>
>
> A couple of the BOOKKEEPER-237 jiras need to add new exceptions. This jira
> creates the umbrella exception which they can all go under.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira