[ 
https://issues.apache.org/jira/browse/BOOKKEEPER-317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13401244#comment-13401244
 ] 

Rakesh R commented on BOOKKEEPER-317:
-------------------------------------

@Ivan
Its great and will avoid cross overs. 

Just one comment - It would be good to have @SuppressWarnings("serial") in 
class level, just to avoid the following
{code}
The serializable class ReplicationException does not declare a static final 
serialVersionUID field of type 
 long
{code}

                
> Exceptions for replication
> --------------------------
>
>                 Key: BOOKKEEPER-317
>                 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-317
>             Project: Bookkeeper
>          Issue Type: Sub-task
>            Reporter: Ivan Kelly
>            Assignee: Ivan Kelly
>             Fix For: 4.2.0
>
>         Attachments: BOOKKEEPER-317.diff
>
>
> A couple of the BOOKKEEPER-237 jiras need to add new exceptions. This jira 
> creates the umbrella exception which they can all go under.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to