[ 
https://issues.apache.org/jira/browse/BOOKKEEPER-247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13404723#comment-13404723
 ] 

Uma Maheswara Rao G commented on BOOKKEEPER-247:
------------------------------------------------

Great :-)

Thanks a lot for addressing the issue.

I have some scenarios verified tests, I should have included them in my 
previous patch, but don't want to messup with the patch which explains the 
problem.
Now I have updated the patch with the below minor modifications and newly added 
tests.

- added javadoc for hasEntry methods.
- updated correct header comments in DistributedSchedule, RRDSchedule algorithm.
- Included some more tests which I have added recently.
- Made the inner classes of LedgerChecker as private static. 
- also updated the class level javadocs for LedgerChecker and LedgerFragment.

If you like the changes, you can push this to your git and make it ready for 
review with your added tests. And many of the scenarios works well for me.
                
> Detection of under replication
> ------------------------------
>
>                 Key: BOOKKEEPER-247
>                 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-247
>             Project: Bookkeeper
>          Issue Type: Sub-task
>          Components: bookkeeper-client, bookkeeper-server
>            Reporter: Ivan Kelly
>            Assignee: Ivan Kelly
>         Attachments: BOOKKEEPER-247.diff, BOOKKEEPER-247.diff, 
> BOOKKEEPER-247.patch, BOOKKEEPER-247.patch
>
>
> This JIRA discusses how the bookkeeper system will detect underreplication of 
> ledger entries.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to