[ 
https://issues.apache.org/jira/browse/BOOKKEEPER-247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13407182#comment-13407182
 ] 

Ivan Kelly commented on BOOKKEEPER-247:
---------------------------------------

The first case (single entry in ledger) is actually straightforward to fix. The 
problem is that the fragment to check has the last entry set wrong, so it never 
actually checks. 
https://github.com/ivankelly/bookkeeper/commit/73b55018efdc451b356781fbe9b25a148878b308

The empty ledger problem im not so sure of how to fix. It's not obvious how to 
tell the difference between. There's already a test case for this 
#testShouldNotGetAnyFragmentWithEmptyLedger

Btw, if you guys want to add changes to the patch, could you clone the github 
branch, and make the mods there. It makes it easier to track what the changes 
between the patches are. 
                
> Detection of under replication
> ------------------------------
>
>                 Key: BOOKKEEPER-247
>                 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-247
>             Project: Bookkeeper
>          Issue Type: Sub-task
>          Components: bookkeeper-client, bookkeeper-server
>            Reporter: Ivan Kelly
>            Assignee: Ivan Kelly
>         Attachments: BOOKKEEPER-247-1.patch, BOOKKEEPER-247.diff, 
> BOOKKEEPER-247.diff, BOOKKEEPER-247.patch, BOOKKEEPER-247.patch
>
>
> This JIRA discusses how the bookkeeper system will detect underreplication of 
> ledger entries.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to