-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5101/
-----------------------------------------------------------
(Updated July 8, 2012, 5:29 a.m.)
Review request for bookkeeper.
Changes
-------
attach a new patch addressing Ivan's comments.
Description
-------
it would be better to a ledger-manager like interface to manage metadata
operations in Hedwig, which might be easy for use to adapt to meta store api.
This addresses bug BOOKKEEPER-250.
https://issues.apache.org/jira/browse/BOOKKEEPER-250
Diffs (updated)
-----
hedwig-protocol/src/main/java/org/apache/hedwig/exceptions/PubSubException.java
5cbd318
hedwig-protocol/src/main/java/org/apache/hedwig/protocol/PubSubProtocol.java
a37f945
hedwig-protocol/src/main/protobuf/PubSubProtocol.proto b845c40
hedwig-server/src/main/java/org/apache/hedwig/server/common/ServerConfiguration.java
a37e336
hedwig-server/src/main/java/org/apache/hedwig/server/meta/FactoryLayout.java
PRE-CREATION
hedwig-server/src/main/java/org/apache/hedwig/server/meta/MetadataManagerFactory.java
PRE-CREATION
hedwig-server/src/main/java/org/apache/hedwig/server/meta/SubscriptionDataManager.java
PRE-CREATION
hedwig-server/src/main/java/org/apache/hedwig/server/meta/TopicPersistenceManager.java
PRE-CREATION
hedwig-server/src/main/java/org/apache/hedwig/server/meta/ZkMetadataManagerFactory.java
PRE-CREATION
hedwig-server/src/main/java/org/apache/hedwig/server/netty/PubSubServer.java
cb11955
hedwig-server/src/main/java/org/apache/hedwig/server/persistence/BookkeeperPersistenceManager.java
0250401
hedwig-server/src/main/java/org/apache/hedwig/server/persistence/LocalDBPersistenceManager.java
a8b9f74
hedwig-server/src/main/java/org/apache/hedwig/server/persistence/PersistenceManager.java
0ee0a9b
hedwig-server/src/main/java/org/apache/hedwig/server/subscriptions/MMSubscriptionManager.java
PRE-CREATION
hedwig-server/src/main/java/org/apache/hedwig/server/subscriptions/ZkSubscriptionManager.java
4d39335
hedwig-server/src/main/java/org/apache/hedwig/zookeeper/ZkUtils.java c377e04
hedwig-server/src/test/java/org/apache/hedwig/server/meta/MetadataManagerFactoryTestCase.java
PRE-CREATION
hedwig-server/src/test/java/org/apache/hedwig/server/meta/TestFactoryLayout.java
PRE-CREATION
hedwig-server/src/test/java/org/apache/hedwig/server/meta/TestMetadataManager.java
PRE-CREATION
hedwig-server/src/test/java/org/apache/hedwig/server/meta/TestMetadataManagerFactory.java
PRE-CREATION
hedwig-server/src/test/java/org/apache/hedwig/server/persistence/StubPersistenceManager.java
fecf861
hedwig-server/src/test/java/org/apache/hedwig/server/persistence/TestBookKeeperPersistenceManager.java
0fb4fe4
hedwig-server/src/test/java/org/apache/hedwig/server/persistence/TestBookKeeperPersistenceManagerBlackBox.java
57bc95d
hedwig-server/src/test/java/org/apache/hedwig/server/persistence/TestBookkeeperPersistenceManagerWhiteBox.java
216cd8a
hedwig-server/src/test/java/org/apache/hedwig/server/persistence/TestPersistenceManagerBlackBox.java
ce82c0b
hedwig-server/src/test/java/org/apache/hedwig/server/subscriptions/TestMMSubscriptionManager.java
PRE-CREATION
hedwig-server/src/test/java/org/apache/hedwig/server/subscriptions/TestZkSubscriptionManager.java
9558acf
Diff: https://reviews.apache.org/r/5101/diff/
Testing
-------
Thanks,
Sijie Guo
