----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5101/#review9016 -----------------------------------------------------------
hedwig-server/src/main/java/org/apache/hedwig/server/meta/FactoryLayout.java <https://reviews.apache.org/r/5101/#comment19171> Adding layoutVersion and LSEP is unnecessary become this is the first time we'll be added a layout version, and it's already protobuf. The only reason we had to use it for bookkeeper was that there was already a serialization format, and it's needed to decide whether to deserialize with the old format or with protobuf. hedwig-server/src/main/java/org/apache/hedwig/server/meta/MetadataManagerFactory.java <https://reviews.apache.org/r/5101/#comment19175> make this protected so that it can only be called by subclasses and newMetadataManagerFactory hedwig-server/src/main/java/org/apache/hedwig/server/meta/MetadataManagerFactory.java <https://reviews.apache.org/r/5101/#comment19174> It would be better to call this shutdown. uninitialize indicates that the object can be reinitialized. - Ivan Kelly On July 8, 2012, 5:29 a.m., Sijie Guo wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/5101/ > ----------------------------------------------------------- > > (Updated July 8, 2012, 5:29 a.m.) > > > Review request for bookkeeper. > > > Description > ------- > > it would be better to a ledger-manager like interface to manage metadata > operations in Hedwig, which might be easy for use to adapt to meta store api. > > > This addresses bug BOOKKEEPER-250. > https://issues.apache.org/jira/browse/BOOKKEEPER-250 > > > Diffs > ----- > > > hedwig-protocol/src/main/java/org/apache/hedwig/exceptions/PubSubException.java > 5cbd318 > > hedwig-protocol/src/main/java/org/apache/hedwig/protocol/PubSubProtocol.java > a37f945 > hedwig-protocol/src/main/protobuf/PubSubProtocol.proto b845c40 > > hedwig-server/src/main/java/org/apache/hedwig/server/common/ServerConfiguration.java > a37e336 > > hedwig-server/src/main/java/org/apache/hedwig/server/meta/FactoryLayout.java > PRE-CREATION > > hedwig-server/src/main/java/org/apache/hedwig/server/meta/MetadataManagerFactory.java > PRE-CREATION > > hedwig-server/src/main/java/org/apache/hedwig/server/meta/SubscriptionDataManager.java > PRE-CREATION > > hedwig-server/src/main/java/org/apache/hedwig/server/meta/TopicPersistenceManager.java > PRE-CREATION > > hedwig-server/src/main/java/org/apache/hedwig/server/meta/ZkMetadataManagerFactory.java > PRE-CREATION > > hedwig-server/src/main/java/org/apache/hedwig/server/netty/PubSubServer.java > cb11955 > > hedwig-server/src/main/java/org/apache/hedwig/server/persistence/BookkeeperPersistenceManager.java > 0250401 > > hedwig-server/src/main/java/org/apache/hedwig/server/persistence/LocalDBPersistenceManager.java > a8b9f74 > > hedwig-server/src/main/java/org/apache/hedwig/server/persistence/PersistenceManager.java > 0ee0a9b > > hedwig-server/src/main/java/org/apache/hedwig/server/subscriptions/MMSubscriptionManager.java > PRE-CREATION > > hedwig-server/src/main/java/org/apache/hedwig/server/subscriptions/ZkSubscriptionManager.java > 4d39335 > hedwig-server/src/main/java/org/apache/hedwig/zookeeper/ZkUtils.java > c377e04 > > hedwig-server/src/test/java/org/apache/hedwig/server/meta/MetadataManagerFactoryTestCase.java > PRE-CREATION > > hedwig-server/src/test/java/org/apache/hedwig/server/meta/TestFactoryLayout.java > PRE-CREATION > > hedwig-server/src/test/java/org/apache/hedwig/server/meta/TestMetadataManager.java > PRE-CREATION > > hedwig-server/src/test/java/org/apache/hedwig/server/meta/TestMetadataManagerFactory.java > PRE-CREATION > > hedwig-server/src/test/java/org/apache/hedwig/server/persistence/StubPersistenceManager.java > fecf861 > > hedwig-server/src/test/java/org/apache/hedwig/server/persistence/TestBookKeeperPersistenceManager.java > 0fb4fe4 > > hedwig-server/src/test/java/org/apache/hedwig/server/persistence/TestBookKeeperPersistenceManagerBlackBox.java > 57bc95d > > hedwig-server/src/test/java/org/apache/hedwig/server/persistence/TestBookkeeperPersistenceManagerWhiteBox.java > 216cd8a > > hedwig-server/src/test/java/org/apache/hedwig/server/persistence/TestPersistenceManagerBlackBox.java > ce82c0b > > hedwig-server/src/test/java/org/apache/hedwig/server/subscriptions/TestMMSubscriptionManager.java > PRE-CREATION > > hedwig-server/src/test/java/org/apache/hedwig/server/subscriptions/TestZkSubscriptionManager.java > 9558acf > > Diff: https://reviews.apache.org/r/5101/diff/ > > > Testing > ------- > > > Thanks, > > Sijie Guo > >
