[ 
https://issues.apache.org/jira/browse/BOOKKEEPER-327?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13408851#comment-13408851
 ] 

Uma Maheswara Rao G commented on BOOKKEEPER-327:
------------------------------------------------

Thanks a lot, Sijie for taking a look.

I also convened with you about negative check. Because that is the case where 
it should not happen, Just logged the warn.
Why I was thinking to reserve one bucket is, if some wants to check whether 
there are many such cases are there or not. But thinking again, this is an 
unexpected case and may not occur regularly, so that bucket will not utilized 
and also may not help to the user. Warn message can help in that case.

Updated the patch. Could you please take a look.
 
                
> System.currentTimeMillis usage in BookKeeper
> --------------------------------------------
>
>                 Key: BOOKKEEPER-327
>                 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-327
>             Project: Bookkeeper
>          Issue Type: Bug
>    Affects Versions: 4.0.0, 4.1.0
>            Reporter: Rakesh R
>            Priority: Minor
>         Attachments: BOOKKEEPER-327.patch, BOOKKEEPER-327.patch
>
>
> The following exception occured in the bookie statistics logic due to the 
> System time changes. In our bookie cluster its running a periodic syncup 
> scripts just to unify the SystemTime in all the machines. This is causing the 
> problem and resulting ArrayIndexOutOfBoundException.
> {code}
> Exception in thread "BookieJournal-3181" 
> java.lang.ArrayIndexOutOfBoundsException: -423
> at org.apache.bookkeeper.proto.BKStats$OpStats.updateLatency(BKStats.java:126)
> at 
> org.apache.bookkeeper.proto.BookieServer.writeComplete(BookieServer.java:655)
> at org.apache.bookkeeper.bookie.Journal.run(Journal.java:507)
> {code}
> This jira is raised to discuss whether to use ??System.nanoTime()?? instead 
> of ??System.currentTimeMillis()??

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to