[
https://issues.apache.org/jira/browse/BOOKKEEPER-327?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13409223#comment-13409223
]
Uma Maheswara Rao G commented on BOOKKEEPER-327:
------------------------------------------------
{noformat}
/**
* Equivalent to <tt>NANOSECONDS.convert(duration, this)</tt>.
* @param duration the duration
* @return the converted duration,
* or <tt>Long.MIN_VALUE</tt> if conversion would negatively
* overflow, or <tt>Long.MAX_VALUE</tt> if it would positively overflow.
* @see #convert
*/
{noformat}
Here it will automatically conevrting on overflow the values and returning
Long.MAX_VALUES or MIN_VALUE respectively.
Here in latency we want to ignore on such nagative cases. Also it present in
concurrent package. I feel, its ok for this small math operation in
MathUtils.java.
> System.currentTimeMillis usage in BookKeeper
> --------------------------------------------
>
> Key: BOOKKEEPER-327
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-327
> Project: Bookkeeper
> Issue Type: Bug
> Affects Versions: 4.0.0, 4.1.0
> Reporter: Rakesh R
> Priority: Minor
> Attachments: BOOKKEEPER-327-1.patch, BOOKKEEPER-327.patch,
> BOOKKEEPER-327.patch
>
>
> The following exception occured in the bookie statistics logic due to the
> System time changes. In our bookie cluster its running a periodic syncup
> scripts just to unify the SystemTime in all the machines. This is causing the
> problem and resulting ArrayIndexOutOfBoundException.
> {code}
> Exception in thread "BookieJournal-3181"
> java.lang.ArrayIndexOutOfBoundsException: -423
> at org.apache.bookkeeper.proto.BKStats$OpStats.updateLatency(BKStats.java:126)
> at
> org.apache.bookkeeper.proto.BookieServer.writeComplete(BookieServer.java:655)
> at org.apache.bookkeeper.bookie.Journal.run(Journal.java:507)
> {code}
> This jira is raised to discuss whether to use ??System.nanoTime()?? instead
> of ??System.currentTimeMillis()??
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
