[
https://issues.apache.org/jira/browse/BOOKKEEPER-311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13420570#comment-13420570
]
Sijie Guo commented on BOOKKEEPER-311:
--------------------------------------
@Flavio,
>> There is one TODO in the patch
Created BOOKKEEPER-350 for it and marked it as dependency for BOOKKEEPER-312.
>> This patch seems to introduce a discrepancy between the api of the java and
>> of the C clients.
BOOKKEEPER-339 is created to support returning message seq id for cpp client.
Since BOOKKEEPER-350 and BOOKKEEPER-331 has been created to track two
requirements for JMS provider, I would move BOOKKEEPER-309, BOOKKEEPER-310,
BOOKKEEPER-311 as sub-tasks for BOOKKEEPER-331.
>> FORMAT.
Agreed. @Mridul, could you provide a new patch according to BookKeeper's code
style.
> Changes in hedwig client api to support JMS spec
> ------------------------------------------------
>
> Key: BOOKKEEPER-311
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-311
> Project: Bookkeeper
> Issue Type: Sub-task
> Reporter: Mridul Muralidharan
> Attachments: hedwig-client-consume.patch.1,
> hedwig-client-publish.patch.1, hedwig-client.patch, hedwig-client.patch.3,
> hedwig-client.patch.4
>
>
> Primary changes are :
> a) Add support for returning seq-id for a publish request. This is an api
> change (backwardly compatible for users).
> b) Make consume a sync consume, with addition of an asyncConsume - this is to
> ensure that invoking consume() ensure request makes to server before
> returning (with what reasonable gaurantees that netty allows).
> c) Ensure that explicit close'ing of session will flush buffered consume
> seq-id's when auto-ack is enabled (default in hedwig java client).
> In addition, there are also fixes for
> d) Fix NPE's observed as part of testing JMS provider.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
