[
https://issues.apache.org/jira/browse/BOOKKEEPER-311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13424780#comment-13424780
]
Uma Maheswara Rao G commented on BOOKKEEPER-311:
------------------------------------------------
Yes, 80 characters per line will be small in some cases and code may looks ugly
if we wrap it to 2 lines. Recently, Hbase also revisited for this point and
made their convention to 100+, I remember.
May be, we can have that discussion in the mailing list?
{quote}
is that we have been just loosely following the code conventions we have set
for the project, mainly because they are too strict.
{quote}
I am not sure, anyone is violating these conventions. IMO, we have to be very
strict towards the conventions for the long term maintenance(neatly) of the
code. Otherwise, code will become too ugly with the different conventions
placed.
> Changes in hedwig client api to support JMS spec
> ------------------------------------------------
>
> Key: BOOKKEEPER-311
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-311
> Project: Bookkeeper
> Issue Type: Sub-task
> Reporter: Mridul Muralidharan
> Assignee: Mridul Muralidharan
> Attachments: hedwig-client-consume.patch.1,
> hedwig-client-publish.patch.1, hedwig-client.patch, hedwig-client.patch.3,
> hedwig-client.patch.4, hedwig-client.patch.5
>
>
> Primary changes are :
> a) Add support for returning seq-id for a publish request. This is an api
> change (backwardly compatible for users).
> b) Make consume a sync consume, with addition of an asyncConsume - this is to
> ensure that invoking consume() ensure request makes to server before
> returning (with what reasonable gaurantees that netty allows).
> c) Ensure that explicit close'ing of session will flush buffered consume
> seq-id's when auto-ack is enabled (default in hedwig java client).
> In addition, there are also fixes for
> d) Fix NPE's observed as part of testing JMS provider.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
