[ 
https://issues.apache.org/jira/browse/BOOKKEEPER-283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13436615#comment-13436615
 ] 

Ivan Kelly commented on BOOKKEEPER-283:
---------------------------------------

- Why are you returning ByteString from getTopics() source data is always 
String and the caller converts it back into String straight away anyhow.
- pressKeyToContinue should accept any key to continue, as there is only one 
possible continuation. I haven't run it, but from the look of it, it would 
require a Y<Return> to continue. 

                
> Improve Hedwig Console to use Hedwig Metadata Manager.
> ------------------------------------------------------
>
>                 Key: BOOKKEEPER-283
>                 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-283
>             Project: Bookkeeper
>          Issue Type: Sub-task
>          Components: hedwig-server
>            Reporter: Sijie Guo
>            Assignee: Sijie Guo
>             Fix For: 4.2.0
>
>         Attachments: BOOKKEEPER-283.diff, BOOKKEEPER-283.diff, 
> BOOKKEEPER-283.diff_v2
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to