[ 
https://issues.apache.org/jira/browse/BOOKKEEPER-283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13436635#comment-13436635
 ] 

Sijie Guo commented on BOOKKEEPER-283:
--------------------------------------

> Why are you returning ByteString from getTopics() source data is always 
> String and the caller converts it back into String straight away anyhow.

As all the hedwig uses ByteString for topic name, so we need to stick to the 
style.

> pressKeyToContinue should accept any key to continue, as there is only one 
> possible continuation. 

it did accept any key to continue. just when user press 'y' or 'Y', it 
continues showing next topic list. pressing other key would stop showing next 
topic list.
                
> Improve Hedwig Console to use Hedwig Metadata Manager.
> ------------------------------------------------------
>
>                 Key: BOOKKEEPER-283
>                 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-283
>             Project: Bookkeeper
>          Issue Type: Sub-task
>          Components: hedwig-server
>            Reporter: Sijie Guo
>            Assignee: Sijie Guo
>             Fix For: 4.2.0
>
>         Attachments: BOOKKEEPER-283.diff, BOOKKEEPER-283.diff, 
> BOOKKEEPER-283.diff_v2
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to