[
https://issues.apache.org/jira/browse/BOOKKEEPER-248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13438651#comment-13438651
]
Uma Maheswara Rao G commented on BOOKKEEPER-248:
------------------------------------------------
Thanks a lot Ivan for the review!
{quote}
In ReplicationWorker#run, don't catch a Throwable. This will catch exceptions
which you really don't want to catch, specifically, RuntimeExceptions like
NullPointerException or ArithmeticException which are a result of programming
error.
{quote}
Yes, Ivan, I added TODO inside throwable to keep this point in mind.
I will try to catch all exceptions specifically now and will discuss after that.
{quote}
The flow is a bit strange between #run() and #doReplicateFragments(). You're
interacting with underreplicationManager in both, depending on booleans etc. I
think it would be cleaer to put all the interaction with
underreplicationManager in run(). The boolean return from doReplicateFragments
seems to be designed especially for this.
{quote}
Infact, I just extracted that to doReplicateFragments method from run method
only :-).
That is mainly because, keeping pending replicationsMonitor in my mind.
After delaying for some ledger replication, and after timeout I wanted to reuse
this method from there to replicate.
Anyway, Now I will make it inline, once I moved to that JIRA, we will discuss
there.
Others I will take a look to address.
Thanks a lot.
+Uma
> Rereplicating of under replicated data
> --------------------------------------
>
> Key: BOOKKEEPER-248
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-248
> Project: Bookkeeper
> Issue Type: Sub-task
> Components: bookkeeper-client, bookkeeper-server
> Reporter: Ivan Kelly
> Assignee: Uma Maheswara Rao G
> Fix For: 4.2.0
>
> Attachments: BOOKKEEPER-248.patch
>
>
> This subtask discusses how we will rereplicate underreplicated entries.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
