[
https://issues.apache.org/jira/browse/BOOKKEEPER-248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13439794#comment-13439794
]
Uma Maheswara Rao G commented on BOOKKEEPER-248:
------------------------------------------------
Attached a new revision of patch which addresses the comments.
Found 2 issues while testing. One I explained in my previous comment and other
issue with GC (raised as a separate JIRA BK-376)
And regarding the below comment
{quote}
ReplicationWorker#stop() should wait for #run() to have finished before
cleaning up the bk client. Otherwise you're asking for null pointer exceptions
to happen. Have a look guava Service [1]. It may be worth using
{quote}
Actually I am initialing the required stuff in RW ctor only and all were light
wait. I did not see the possibility of null pointer there.
Infact, introducing the guava Service would be a good idea and with my
limited(used) familiarity on Guava service and time, I could not really
introduce it now. If you don't mind I will replace it once I get some
familiarity on it and will raise small task later.
Could you please take a look on the patch.
> Rereplicating of under replicated data
> --------------------------------------
>
> Key: BOOKKEEPER-248
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-248
> Project: Bookkeeper
> Issue Type: Sub-task
> Components: bookkeeper-client, bookkeeper-server
> Reporter: Ivan Kelly
> Assignee: Uma Maheswara Rao G
> Fix For: 4.2.0
>
> Attachments: BOOKKEEPER-248.patch, BOOKKEEPER-248.patch
>
>
> This subtask discusses how we will rereplicate underreplicated entries.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
