[
https://issues.apache.org/jira/browse/BOOKKEEPER-300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13447624#comment-13447624
]
Vinay commented on BOOKKEEPER-300:
----------------------------------
Hi Uma, here are some of the clarifications on above comments.
{quote}I think, it may be good to have prechecks to ensure LedgerDirs &
JournalDir are configured, otherwise it may endup with NPEs right?{quote}
If journalDir and ledgerDirs are not configured, then Configuration will return
default values /tmp/bk-txn and /tmp/bk-data. So Null check not required.
{quote}in createNewLMFactory
getLedgerManagerType is deprecated instead, please use
getLedgerManagerFactoryClass{quote}
getLedgerManagerFactoryClass(..) also used before calling
createNewLMFactory(..). But for backward compatibility, getLedgerManagerType()
is used. This code was present earlier. I just extracted to common method. ;)
Other comments I will fix and post a new patch soon....
> Create Bookie format command
> ----------------------------
>
> Key: BOOKKEEPER-300
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-300
> Project: Bookkeeper
> Issue Type: New Feature
> Components: bookkeeper-server
> Affects Versions: 4.1.0
> Reporter: Rakesh R
> Assignee: Vinay
> Fix For: 4.2.0
>
> Attachments: BOOKKEEPER-300.patch, BOOKKEEPER-300.patch,
> BOOKKEEPER-300.patch, BOOKKEEPER-300.patch, BOOKKEEPER-300.patch
>
>
> Provide a bookie format command. Then the admin would just have to run the
> command on each machine, which will prepare the bookie env
> +Zookeeper paths (znodes):+
> - ledger's root path
> - bookie's available path
> +Directories:+
> - Journal directories
> - Ledger directories
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
