[
https://issues.apache.org/jira/browse/BOOKKEEPER-402?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13455734#comment-13455734
]
Sijie Guo commented on BOOKKEEPER-402:
--------------------------------------
{code}
Also, we should also stop delivery if we get a channel disconnected event for a
subscription channel in SubscribeHandler.
{code}
Currently even we don't stop delivery explicitly, the active subscriber would
stop delivery when encountering permanent error (channel disconnected). the
only point worths to do that is to remove the memory occupied by zombie active
subscriber. from this side, I would prefer not adding another mapping in
subhandler, especially when a hub server serving lots of topics and subscribers.
> One reason to keep this out of the subscription manager was to keep the two
> components decoupled
I agree decoupling things. so I want to keep handlers simple. currently
subhandler is too tight to manage subscription channels (I moved this part to a
separate place to manage subscription channels when working for BOOKKEEPER-70).
it would keep simple as other handler like unsubscribe, publish.
after multiplexing, we should not close the channel directly in client-side. so
we had closeSubscription request to stopDelivery a subscriber, and we also need
to handle stopDelivery for a unsubscribe request. so the subscription manager
needs to tell deliveryManager to stopDelivery for a subscriber when
closeSubscription and unsubscribe. If not, we had to scatter the delivery
manager to all request handlers when adding new type of requests.
> Hedwig hub should close subscription channels on losing a topic
> ---------------------------------------------------------------
>
> Key: BOOKKEEPER-402
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-402
> Project: Bookkeeper
> Issue Type: Bug
> Components: hedwig-server
> Reporter: Aniruddha
>
> If a hub were to lose a topic, it doesn't stop delivery for that topic and
> keeps the subscription channels open. It should actively close it and stop
> delivery for all subscribers for that topic connected to it.
> Reviewboard entry: https://reviews.apache.org/r/7054/
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
