[
https://issues.apache.org/jira/browse/BOOKKEEPER-319?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13457201#comment-13457201
]
Uma Maheswara Rao G commented on BOOKKEEPER-319:
------------------------------------------------
Hi Vinay, thanks for the patch.
{code}
private ZooKeeper getNewZookeeper(ServerConfiguration conf)
+ throws IOException, InterruptedException, KeeperException {
+ ZooKeeper newZk = ZkUtils.getNewZookeeperClient(conf.getZkServers(),
+ conf.getZkTimeout(), new Watcher() {
{code}
Please use ZKUtils#getNewConnectedClient instead, as you added it recently in
format patch.
{code}
*/
+ public void join() throws InterruptedException {
+ synchronized (this) {
+ while (auditorElector.isRunning()) {
+ wait(100);
+ }
+ while (replicationWorker.isRunning()) {
+ wait(100);
+ }
+ }
{code}
Could you please give me a hint why you added this log in join, did not strikes
it to me on first look.
anyway shutdown is calling auditor and rw shutdown, so they will be interrupted
and joined there?
Simply why can't we add add join in this method?
{code}
private static class AuditorPeerDeathWatcher extends Thread {
+ int watchInterval;
+ AuditorPeer peer;
{code}
why can't we make these variable private?
{code}
new File(confFile).toURI().toURL()
{code}
directly also, you can convert to url right? any issue?
{code}
} catch (Exception e) {
+ LOG.error("Exception running bookie server : ", e);
{code}
Why bookie server?
{code}
"Shut down AuditorPeer
{code}
typo?
isRunning --> add small doc for this
These are some comments on first look. Did not take a look into tests much
I would request, Ivan to take a look for better naming here for the process.
Also please add your comments
> Manage auditing and replication processes
> -----------------------------------------
>
> Key: BOOKKEEPER-319
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-319
> Project: Bookkeeper
> Issue Type: Sub-task
> Components: bookkeeper-auto-recovery
> Reporter: Rakesh R
> Assignee: Vinay
> Fix For: 4.2.0
>
> Attachments: BOOKKEEPER-319.patch
>
>
> This subtask discusses, how we will manage the whole rereplication processes.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
