[
https://issues.apache.org/jira/browse/BOOKKEEPER-319?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13459659#comment-13459659
]
Ivan Kelly commented on BOOKKEEPER-319:
---------------------------------------
Patch looks good, but needs a rebase against trunk. I have the following
comments.
For naming I would suggest calling the command (for the bash script), "autorec"
or "autorecovery", and the main class "AutoRecoveryMain". We shouldn't expose
the actual implementation to the user, we just want to them to know that a auto
recovery service is available.
Typo in the name of the death watcher thread.
The help for "conf" should be "Bookie server configuration".
A ParseException in parseArgs will cause the same error to be printed twice.
In printUsage, there should be no "or". It should be
{code}
hf.printHelp("AutoRecoveryMain [options]\n", opts);
{code}
getMyBookieAddress can be static.
getNewZookeeper exists in AuditorPeer and in ZkUtils. There is already a
version of it in ZkUtils now as well.
Also, you're catching Exception e in main(). Could you run "mvn install
findbugs:check" once you've rebased to ensure this isn't causing a findbugs
error.
> Manage auditing and replication processes
> -----------------------------------------
>
> Key: BOOKKEEPER-319
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-319
> Project: Bookkeeper
> Issue Type: Sub-task
> Components: bookkeeper-auto-recovery
> Reporter: Rakesh R
> Assignee: Vinay
> Fix For: 4.2.0
>
> Attachments: BOOKKEEPER-319.patch
>
>
> This subtask discusses, how we will manage the whole rereplication processes.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
