[
https://issues.apache.org/jira/browse/BOOKKEEPER-422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13473063#comment-13473063
]
Stu Hood commented on BOOKKEEPER-422:
-------------------------------------
bq. I am not sure this change does better, since each time
#hasLocalSubscriptions needs to go thru all the subscriptions.
The javadoc on that method explains that it exits as soon as it finds a
non-local subscription, which should be very, very quickly (unless cross-region
subscribers vastly outnumber local subscribers.)
> Simplify AbstractSubscriptionManager
> ------------------------------------
>
> Key: BOOKKEEPER-422
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-422
> Project: Bookkeeper
> Issue Type: Improvement
> Components: hedwig-server
> Reporter: Stu Hood
> Assignee: Stu Hood
> Priority: Minor
> Attachments: bk-422.diff, bk-422.diff
>
>
> It's difficult to maintain a duplicated/cached count of local subscribers,
> and we've experienced a few issues due to it getting out of sync with the
> actual set of subscribers. Since a count of local subscribers can be
> calculated from the top2sub2seq map, let's do that instead.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
