[ 
https://issues.apache.org/jira/browse/BOOKKEEPER-422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13473538#comment-13473538
 ] 

Stu Hood commented on BOOKKEEPER-422:
-------------------------------------

bq. One way would be to split top2sub2seq into two data structures, one for 
local and one for non-local.
Unless the number of regions begins to get into the thousands this will not be 
necessary for performance reasons.

And in terms of clarity, I'm thinking that the long term direction will be that 
we have a subscriber-specific data structure of some kind which would make the 
string parsing unnecessary, and further clarify the 'hasLocalSubscriptions' 
call. So, IMO: splitting the map before we really need to would be premature.
                
> Simplify AbstractSubscriptionManager
> ------------------------------------
>
>                 Key: BOOKKEEPER-422
>                 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-422
>             Project: Bookkeeper
>          Issue Type: Improvement
>          Components: hedwig-server
>            Reporter: Stu Hood
>            Assignee: Stu Hood
>            Priority: Minor
>         Attachments: bk-422.diff, bk-422.diff, bk-422.diff
>
>
> It's difficult to maintain a duplicated/cached count of local subscribers, 
> and we've experienced a few issues due to it getting out of sync with the 
> actual set of subscribers. Since a count of local subscribers can be 
> calculated from the top2sub2seq map, let's do that instead.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to