[ 
https://issues.apache.org/jira/browse/BOOKKEEPER-428?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13486646#comment-13486646
 ] 

Uma Maheswara Rao G commented on BOOKKEEPER-428:
------------------------------------------------

Hi Rakesh,

- Currently we missed options to document anywhere as a help message.
- Actually I feel that the shell interactions can go to BookieShell class and 
provide an AutoRecEndisableCmd in that.
 
add them to the map:
 {code}
 commands.put(CMD_METAFORMAT, new MetaFormatCmd());
        commands.put(CMD_BOOKIEFORMAT, new BookieFormatCmd());
        commands.put(CMD_RECOVER, new RecoverCmd());
        commands.put(CMD_LEDGER, new LedgerCmd());
        commands.put(CMD_READLOG, new ReadLogCmd());
        commands.put(CMD_READJOURNAL, new ReadJournalCmd());
        commands.put(CMD_LASTMARK, new LastMarkCmd());
        commands.put(CMD_HELP, new HelpCmd());
{code}

- on handling #2 my first comment will be covered as part of it as it has 
separate HelpCmd exposed via shell.

- I also feel that, we can have a test that should check there are no further 
replications proceeding after disabling it. That test would be a functional 
test to ensure end-end.

Thanks,
Uma
                
> Expose command options in bookie scripts to disable/enable auto recovery 
> temporarily
> ------------------------------------------------------------------------------------
>
>                 Key: BOOKKEEPER-428
>                 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-428
>             Project: Bookkeeper
>          Issue Type: Sub-task
>          Components: bookkeeper-auto-recovery
>    Affects Versions: 4.0.0
>            Reporter: Rakesh R
>            Assignee: Rakesh R
>             Fix For: 4.2.0
>
>         Attachments: BOOKKEEPER-428-1.patch, BOOKKEEPER-428.patch
>
>
> Administrators can invoke disble/enable autorecovery options through bookie 
> shell.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to