[
https://issues.apache.org/jira/browse/BOOKKEEPER-485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13506625#comment-13506625
]
Sijie Guo commented on BOOKKEEPER-485:
--------------------------------------
{quote}
+ } else if (future.isSuccess() && state ==
ConnectionState.DISCONNECTED) {
+ LOG.error("Closed before connection completed, clean
up: " + addr);
+ future.getChannel().close();
+ rc =
BKException.Code.BookieHandleNotAvailableException;
+ channel = null;
+ state = ConnectionState.DISCONNECTED;
{quote}
in this case, you assign the rc code to BookieHandleNotAvailableException. But
it seems no so suitable, because actually the connect operation succeed and
bookie is available. I think we need a better rc code here.
besides that, just be curious why you changed log level from DEBUG to INFO for
connecting message.
> TestFencing hung
> ----------------
>
> Key: BOOKKEEPER-485
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-485
> Project: Bookkeeper
> Issue Type: Bug
> Reporter: Flavio Junqueira
> Assignee: Ivan Kelly
> Priority: Critical
> Fix For: 4.2.0
>
> Attachments:
> 0001-BOOKKEEPER-485-Fix-race-between-PerChannelBookieClie.patch,
> stack-trace-hung.txt
>
>
> ... while testing BOOKKEEPER-477, but I think they are unrelated.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
