[
https://issues.apache.org/jira/browse/BOOKKEEPER-485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13507420#comment-13507420
]
Flavio Junqueira commented on BOOKKEEPER-485:
---------------------------------------------
It looks good, just a couple of comments:
- I don't think this statement is needed: state = ConnectionState.DISCONNECTED;
- The test case is not really deterministic, although I understand that running
it 1000 times will probably trigger it once. I can't come up with a good way of
making it deterministic, though, so it is fine with me to have it like that. I
just wanted to make the point and perhaps have a comment on the description of
the test case for future reference.
- In ZooKeeper, we often have a {@link http://issues.apache.org/...} tag to
link the test case to the jira issue. I like it, so I suggest we use it here
too, but if you people don't like, we don't have to do it. Just a text
reference as you have now is ok.
> TestFencing hung
> ----------------
>
> Key: BOOKKEEPER-485
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-485
> Project: Bookkeeper
> Issue Type: Bug
> Reporter: Flavio Junqueira
> Assignee: Ivan Kelly
> Priority: Critical
> Fix For: 4.2.0
>
> Attachments:
> 0001-BOOKKEEPER-485-Fix-race-between-PerChannelBookieClie.patch,
> stack-trace-hung.txt
>
>
> ... while testing BOOKKEEPER-477, but I think they are unrelated.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
