[
https://issues.apache.org/jira/browse/BOOKKEEPER-453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13526362#comment-13526362
]
Hudson commented on BOOKKEEPER-453:
-----------------------------------
Integrated in bookkeeper-trunk #841 (See
[https://builds.apache.org/job/bookkeeper-trunk/841/])
BOOKKEEPER-453: Extract commonality from MultiplexSubscribeResponseHandler
and SimpleSubscribeResponseHandler and put into an abstract class (sijie via
ivank) (Revision 1418280)
Result = UNSTABLE
ivank :
Files :
* /zookeeper/bookkeeper/trunk/CHANGES.txt
*
/zookeeper/bookkeeper/trunk/hedwig-client/src/main/java/org/apache/hedwig/client/netty/impl/AbstractHChannelManager.java
*
/zookeeper/bookkeeper/trunk/hedwig-client/src/main/java/org/apache/hedwig/client/netty/impl/AbstractSubscribeResponseHandler.java
*
/zookeeper/bookkeeper/trunk/hedwig-client/src/main/java/org/apache/hedwig/client/netty/impl/ActiveSubscriber.java
*
/zookeeper/bookkeeper/trunk/hedwig-client/src/main/java/org/apache/hedwig/client/netty/impl/ResubscribeCallback.java
*
/zookeeper/bookkeeper/trunk/hedwig-client/src/main/java/org/apache/hedwig/client/netty/impl/multiplex/MultiplexHChannelManager.java
*
/zookeeper/bookkeeper/trunk/hedwig-client/src/main/java/org/apache/hedwig/client/netty/impl/multiplex/MultiplexSubscribeResponseHandler.java
*
/zookeeper/bookkeeper/trunk/hedwig-client/src/main/java/org/apache/hedwig/client/netty/impl/multiplex/ResubscribeCallback.java
*
/zookeeper/bookkeeper/trunk/hedwig-client/src/main/java/org/apache/hedwig/client/netty/impl/simple/SimpleHChannelManager.java
*
/zookeeper/bookkeeper/trunk/hedwig-client/src/main/java/org/apache/hedwig/client/netty/impl/simple/SimpleSubscribeResponseHandler.java
*
/zookeeper/bookkeeper/trunk/hedwig-client/src/main/java/org/apache/hedwig/client/netty/impl/simple/SubscribeReconnectCallback.java
> Extract commonality from MultiplexSubscribeResponseHandler and
> SimpleSubscribeResponseHandler and put into an abstract class
> ----------------------------------------------------------------------------------------------------------------------------
>
> Key: BOOKKEEPER-453
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-453
> Project: Bookkeeper
> Issue Type: Sub-task
> Components: hedwig-client, hedwig-server
> Reporter: Ivan Kelly
> Assignee: Sijie Guo
> Fix For: 4.2.0
>
> Attachments:
> 0001-BOOKKEEPER-453-Extract-commonality-from-MultiplexSub.patch,
> BOOKKEEPER-453.diff
>
>
> SimpleSubscribeResponseHandler seems to be a special case of
> MultiplexSubscribeResponseHandler (i.e, a multiplex subscribe response
> handler with only one topic subscriber).
> It would be good to take advantage of this to reduce future maintenance costs.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
