[
https://issues.apache.org/jira/browse/BOOKKEEPER-453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13526204#comment-13526204
]
Hadoop QA commented on BOOKKEEPER-453:
--------------------------------------
Testing JIRA BOOKKEEPER-453
Patch
[BOOKKEEPER-453.diff|https://issues.apache.org/jira/secure/attachment/12559822/BOOKKEEPER-453.diff]
downloaded at Fri Dec 7 07:21:46 UTC 2012
----------------------------
{color:green}+1 PATCH_APPLIES{color}
{color:green}+1 CLEAN{color}
{color:red}-1 RAW_PATCH_ANALYSIS{color}
. {color:green}+1{color} the patch does not introduce any @author tags
. {color:green}+1{color} the patch does not introduce any tabs
. {color:red}-1{color} the patch contains 10 line(s) with trailing spaces
. {color:red}-1{color} the patch contains 3 line(s) longer than 120
characters
. {color:red}-1{color} the patch does not add/modify any testcase
{color:green}+1 RAT{color}
. {color:green}+1{color} the patch does not seem to introduce new RAT
warnings
{color:green}+1 JAVADOC{color}
. {color:green}+1{color} the patch does not seem to introduce new Javadoc
warnings
{color:green}+1 COMPILE{color}
. {color:green}+1{color} HEAD compiles
. {color:green}+1{color} patch compiles
. {color:green}+1{color} the patch does not seem to introduce new javac
warnings
{color:green}+1 FINDBUGS{color}
. {color:green}+1{color} the patch does not seem to introduce new Findbugs
warnings
{color:green}+1 TESTS{color}
. Tests run: 393
{color:green}+1 DISTRO{color}
. {color:green}+1{color} distro tarball builds with the patch
----------------------------
{color:red}*-1 Overall result, please check the reported -1(s)*{color}
The full output of the test-patch run is available at
. https://builds.apache.org/job/bookkeeper-trunk-precommit-build/80/
> Extract commonality from MultiplexSubscribeResponseHandler and
> SimpleSubscribeResponseHandler and put into an abstract class
> ----------------------------------------------------------------------------------------------------------------------------
>
> Key: BOOKKEEPER-453
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-453
> Project: Bookkeeper
> Issue Type: Sub-task
> Components: hedwig-client, hedwig-server
> Reporter: Ivan Kelly
> Assignee: Sijie Guo
> Fix For: 4.2.0
>
> Attachments: BOOKKEEPER-453.diff
>
>
> SimpleSubscribeResponseHandler seems to be a special case of
> MultiplexSubscribeResponseHandler (i.e, a multiplex subscribe response
> handler with only one topic subscriber).
> It would be good to take advantage of this to reduce future maintenance costs.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
