[ 
https://issues.apache.org/jira/browse/BOOKKEEPER-365?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13530265#comment-13530265
 ] 

Sijie Guo commented on BOOKKEEPER-365:
--------------------------------------

{quote}
ah, so the test in BOOKKEEPER-355 and your test are different. I didn't go 
through them line by line, as they looked very similiar, I thought you were 
fixing 355 within this patch also.
{quote}

I think it would fix BOOKKEEPER-355 because the test case in BOOKKEEPER-355 is 
not perfect to cover the reason you described.

the solution you described in the previous comment would be the right way to 
fix BOOKKEEPER-355.

{quote}
Is the + 1 correct?
{quote}

Update a new patch to reflect to right meaning of maxMissingReadsAllowed.
                
> Ledger will never recover if one of the quorum bookie is down forever and 
> others dont have entry
> ------------------------------------------------------------------------------------------------
>
>                 Key: BOOKKEEPER-365
>                 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-365
>             Project: Bookkeeper
>          Issue Type: Bug
>    Affects Versions: 4.0.0, 4.1.0
>            Reporter: Sijie Guo
>            Assignee: Sijie Guo
>             Fix For: 4.2.0
>
>         Attachments: BOOKKEEPER-365.diff, BOOKKEEPER-365.diff
>
>
> As discussed in BOOKKEEPER-355, current fix to handle the below issue is not 
> correct. Need to find out new solution
> If some bookies of a quorum gone forever, some bookies of this quorum are 
> still alive but doesn't have that entry (NoSuchEntry or NoSuchLedger), then 
> the ledger doesn't have any evidence to recovery/close it.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to