[
https://issues.apache.org/jira/browse/BOOKKEEPER-496?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13532275#comment-13532275
]
Flavio Junqueira commented on BOOKKEEPER-496:
---------------------------------------------
Here are some more comments:
# doShutdown and doElection have IMPORTANT note. I was wondering if we can
prevent such errors in a more systematic way. In particular, I was wondering if
it would be possible to say make them private to the Runnable we are creating.
# In doElection, should we raise the severity level of the LOG.info messages in
the catch blocks? It could be problematic in some settings to not have the
auditor running.
# Typo in public class AuditorLedgerCheckerTest extends
MultiLedgerManagerTestCase: Received -> Received
# In AuditorElector, LOG.info("Ledger underreplication manage unavailable
during election", e), manage -> manager.
Once we have a new patch, I'll test it.
> Ensure that the auditor and replication worker will shutdown if they lose
> their ZK session
> ------------------------------------------------------------------------------------------
>
> Key: BOOKKEEPER-496
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-496
> Project: Bookkeeper
> Issue Type: Sub-task
> Components: bookkeeper-auto-recovery
> Reporter: Ivan Kelly
> Assignee: Ivan Kelly
> Fix For: 4.2.0
>
> Attachments:
> 0001-BOOKKEEPER-496-Ensure-that-the-auditor-and-replicati.patch,
> 0001-BOOKKEEPER-496-Ensure-that-the-auditor-and-replicati.patch,
> 0001-BOOKKEEPER-496-Ensure-that-the-auditor-and-replicati.patch,
> 0001-BOOKKEEPER-496-Ensure-that-the-auditor-and-replicati.patch,
> BOOKKEEPER-496.patch
>
>
> Once the session is lost, the zookeeper client is invalid. Therefore, we
> should shut down.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
