[ 
https://issues.apache.org/jira/browse/BOOKKEEPER-555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13567540#comment-13567540
 ] 

Ivan Kelly commented on BOOKKEEPER-555:
---------------------------------------

I've benchmarked a single bookie with and without the netty server, using 
bookkeeper-benchmark/bin/benchmark bookie. I ran each 5 times.

||         || Throughput || Stddev || Latency || Stddev ||
| netty    | 22988.4     | 1656.9  | 1.5      | 0.1     |
| no netty | 20785.6     | 1220.4  | 1.5      | 0.1     |

So netty even gives a slight improvement. Therefore, I think this change it 
ready to go. 

The precommit failure is due to the fact that BOOKKEEPER-556 is required. I'll 
kick it off again once BOOKKEEPER-556 is in.
                
> Make BookieServer use Netty rather than a custom IO server
> ----------------------------------------------------------
>
>                 Key: BOOKKEEPER-555
>                 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-555
>             Project: Bookkeeper
>          Issue Type: Bug
>            Reporter: Ivan Kelly
>            Assignee: Ivan Kelly
>             Fix For: 4.3.0
>
>         Attachments: 0002-BOOKKEEPER-555-Netty-Server-for-Bookie.patch, 
> 0002-BOOKKEEPER-555-Netty-Server-for-Bookie.patch
>
>
> Move from the custom NIO server to netty. This will make it easier to do 
> things like add more server side threads and support SSL.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to