[
https://issues.apache.org/jira/browse/BOOKKEEPER-555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13568319#comment-13568319
]
Sijie Guo commented on BOOKKEEPER-555:
--------------------------------------
I haven't go through the details on this patch. but just one comment about
ChannelGroup. There is a known race condition when shutdown a channel group and
adding a opened channel into channel group. if a channel added after closed,
ChannelGroup doesn't take the responsibility of closing it. Then netty would
hang. This issue would exist in Hedwig server too, but it is fine for Hedwig
server, since there is no shutdown hook. But it might be bad for bookie server,
since there is a shutdown hook. A bookie might hang on shutting down. It would
better to extend DefaultChannelGroup to provide a cleanup feature, like
CleanupChannelMap in hedwig client.
similar solution in async-http-client:
http://asynchttpclient.github.com/async-http-client/apidocs/com/ning/http/util/CleanupChannelGroup.html
> Make BookieServer use Netty rather than a custom IO server
> ----------------------------------------------------------
>
> Key: BOOKKEEPER-555
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-555
> Project: Bookkeeper
> Issue Type: Bug
> Reporter: Ivan Kelly
> Assignee: Ivan Kelly
> Fix For: 4.3.0
>
> Attachments: 0002-BOOKKEEPER-555-Netty-Server-for-Bookie.patch,
> 0002-BOOKKEEPER-555-Netty-Server-for-Bookie.patch
>
>
> Move from the custom NIO server to netty. This will make it easier to do
> things like add more server side threads and support SSL.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
