[
https://issues.apache.org/jira/browse/BOOKKEEPER-569?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13577773#comment-13577773
]
Hadoop QA commented on BOOKKEEPER-569:
--------------------------------------
Testing JIRA BOOKKEEPER-569
Patch
[0001-BOOKKEEPER-569-Critical-performance-issue-in-Interle.patch|https://issues.apache.org/jira/secure/attachment/12569224/0001-BOOKKEEPER-569-Critical-performance-issue-in-Interle.patch]
downloaded at Wed Feb 13 17:22:11 UTC 2013
----------------------------
{color:green}+1 PATCH_APPLIES{color}
{color:green}+1 CLEAN{color}
{color:red}-1 RAW_PATCH_ANALYSIS{color}
. {color:green}+1{color} the patch does not introduce any @author tags
. {color:green}+1{color} the patch does not introduce any tabs
. {color:green}+1{color} the patch does not introduce any trailing spaces
. {color:green}+1{color} the patch does not introduce any line longer than
120
. {color:red}-1{color} the patch does not add/modify any testcase
{color:green}+1 RAT{color}
. {color:green}+1{color} the patch does not seem to introduce new RAT
warnings
{color:green}+1 JAVADOC{color}
. {color:green}+1{color} the patch does not seem to introduce new Javadoc
warnings
{color:green}+1 COMPILE{color}
. {color:green}+1{color} HEAD compiles
. {color:green}+1{color} patch compiles
. {color:green}+1{color} the patch does not seem to introduce new javac
warnings
{color:green}+1 FINDBUGS{color}
. {color:green}+1{color} the patch does not seem to introduce new Findbugs
warnings
{color:green}+1 TESTS{color}
. Tests run: 815
{color:green}+1 DISTRO{color}
. {color:green}+1{color} distro tarball builds with the patch
----------------------------
{color:red}*-1 Overall result, please check the reported -1(s)*{color}
The full output of the test-patch run is available at
. https://builds.apache.org/job/bookkeeper-trunk-precommit-build/269/
> Critical performance bug in InterleavedLedgerStorage
> ----------------------------------------------------
>
> Key: BOOKKEEPER-569
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-569
> Project: Bookkeeper
> Issue Type: Bug
> Reporter: Ivan Kelly
> Assignee: Ivan Kelly
> Priority: Blocker
> Fix For: 4.3.0, 4.2.1
>
> Attachments:
> 0001-BOOKKEEPER-569-Critical-performance-issue-in-Interle.patch
>
>
> There's a synchronization on InterleavedLedgerStorage#flush(), which kills
> performance when you're writing to many ledgers on a single bookie. Both
> #flush and #addEntry are synchronized, which blocks any adds being serviced
> while the sync thread is running.
> The sync on #addEntry has always been there, but on #flush it has only
> existed since BOOKKEEPER-293. The addition was obviously a mistake.
> Fix is simply to remove it.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
