[
https://issues.apache.org/jira/browse/BOOKKEEPER-569?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13578937#comment-13578937
]
Sijie Guo commented on BOOKKEEPER-569:
--------------------------------------
+1 for this change. [~fpj] how is your opinion on Ivan's replies? If there is
+1 from you, the patch is ready to be in.
> Critical performance bug in InterleavedLedgerStorage
> ----------------------------------------------------
>
> Key: BOOKKEEPER-569
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-569
> Project: Bookkeeper
> Issue Type: Bug
> Reporter: Ivan Kelly
> Assignee: Ivan Kelly
> Priority: Blocker
> Fix For: 4.3.0, 4.2.1
>
> Attachments:
> 0001-BOOKKEEPER-569-Critical-performance-issue-in-Interle.patch
>
>
> There's a synchronization on InterleavedLedgerStorage#flush(), which kills
> performance when you're writing to many ledgers on a single bookie. Both
> #flush and #addEntry are synchronized, which blocks any adds being serviced
> while the sync thread is running.
> The sync on #addEntry has always been there, but on #flush it has only
> existed since BOOKKEEPER-293. The addition was obviously a mistake.
> Fix is simply to remove it.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
