[
https://issues.apache.org/jira/browse/BOOKKEEPER-557?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13612410#comment-13612410
]
Jiannan Wang commented on BOOKKEEPER-557:
-----------------------------------------
It's a great job, +1 for this patch. Just one comment: since there are many
"SubscriptionOptions.newBuilder().setCreateOrAttach(CreateOrAttach.XXX).build()",
should we build static instance in somewhere and share them instead of
creating new one every time?
By the way, I'm still downloading JDK 7 to verify this patch. Is there any
convenient command to check it? I think for further changes on bookkeeper we
need to check whether the patch works under JDK 7, so a script to do this job
would be very helpful.
> Compiler error showing up badly with jdk 7
> ------------------------------------------
>
> Key: BOOKKEEPER-557
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-557
> Project: Bookkeeper
> Issue Type: Bug
> Reporter: Ivan Kelly
> Assignee: Ivan Kelly
> Fix For: 4.3.0
>
> Attachments:
> 0001-BOOKKEEPER-557-Compiler-error-showing-up-badly-with-.patch,
> 0001-BOOKKEEPER-557-Compiler-error-showing-up-badly-with-.patch,
> 0003-BOOKKEEPER-557-Compiler-error-showing-up-badly-with-.patch
>
>
> JDK 7 changed the error format, and the version of the maven compiler plugin
> we use doesn't like it. The fix is to update the maven compiler plugin.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
