[
https://issues.apache.org/jira/browse/BOOKKEEPER-557?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13612416#comment-13612416
]
Sijie Guo commented on BOOKKEEPER-557:
--------------------------------------
> SubscriptionOptions.newBuilder().setCreateOrAttach(CreateOrAttach.XXX).build()
I don't think we need to build static instance for them. since
SubscriptionOptions not only just CreateOrAttach, there are some other options,
so how to construct SubscriptionOtpions is up to applications. And most of the
changes is for test cases.
> By the way, I'm still downloading JDK 7 to verify this patch. Is there any
> convenient command to check it?
I think the checking depends on your jdk environment. If the jekins job runs
with JDK7, it should check whether the patch works or not. But I am not very
sure whether Ivan changed from JDK6 to JDK7, [~ikelly] ?
> Compiler error showing up badly with jdk 7
> ------------------------------------------
>
> Key: BOOKKEEPER-557
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-557
> Project: Bookkeeper
> Issue Type: Bug
> Reporter: Ivan Kelly
> Assignee: Ivan Kelly
> Fix For: 4.3.0
>
> Attachments:
> 0001-BOOKKEEPER-557-Compiler-error-showing-up-badly-with-.patch,
> 0001-BOOKKEEPER-557-Compiler-error-showing-up-badly-with-.patch,
> 0003-BOOKKEEPER-557-Compiler-error-showing-up-badly-with-.patch
>
>
> JDK 7 changed the error format, and the version of the maven compiler plugin
> we use doesn't like it. The fix is to update the maven compiler plugin.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
