[
https://issues.apache.org/jira/browse/BOOKKEEPER-582?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13624260#comment-13624260
]
Sijie Guo commented on BOOKKEEPER-582:
--------------------------------------
for server side BC, server is easy to detect protocol and handle the packet in
right protocol. all these two proposals handle it. the client side BC, you
tried to handle in handshake isn't tight with protocol, a client could connect
first with new protocol to old server, and old server would respond with
EBADVERSION and downgrade to use an old version protocol. it could be achieved
using either new protobuf protocol.
from my perspective, implementation is a minor thing. but protocol isn't. there
are lots of protobuf definitions in either BOOKKEEPER or Hedwig, how the
community could collaborate on the protocol changes smoothly is the goal I
tried to figure out.
> Make bookie and client use protobuf for requests (non-wire part)
> ----------------------------------------------------------------
>
> Key: BOOKKEEPER-582
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-582
> Project: Bookkeeper
> Issue Type: Sub-task
> Reporter: Ivan Kelly
> Assignee: Ivan Kelly
> Fix For: 4.3.0
>
> Attachments:
> 0002-BOOKKEEPER-582-Make-bookie-and-client-use-protobuf-f.patch,
> 0002-BOOKKEEPER-582-Make-bookie-and-client-use-protobuf-f.patch,
> 0002-BOOKKEEPER-582-Make-bookie-and-client-use-protobuf-f.patch,
> 0003-BOOKKEEPER-582-Make-bookie-and-client-use-protobuf-f.patch
>
>
> Make the client and the bookie use protobufs internally. This is the first
> step to using protobufs on the wire, but for the moment, BookieRequestHandler
> decodes the old wire protocol into the protobuf messages. Once this is in,
> enabling on the wire will be very simple, and the old manual serialization
> can be made "legacy" (still supported, but deprecated).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
