[
https://issues.apache.org/jira/browse/BOOKKEEPER-564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13628016#comment-13628016
]
Sijie Guo commented on BOOKKEEPER-564:
--------------------------------------
the integration is easy due to skiplist extends InterleavedLedgerStorage. but
if another implementation of LedgerStorage is not based
InterleavedLedgerStorage, it has to implement all the things in
InterleavedLedgerStorage again.
-1 for the part that you moved LogMark stuffs (like reading, write marks, which
is part of Journal) into ledger storage, which make the journal constructor of
"Journal(ServerConfiguration conf, LogMark lastLogMark)" looks like that if I
passed any mark, the journal could replay starting from the passed mark. but it
couldn't, since Journal gc its journal files. The mark is part of journal,
which is used to gc its journal files. And Checkpoint#complete is the way to
bridge ledger storage and journal, which tells journal that ledger storage
already synced until this checkpoint and now it is ok for journal to move on
and gc journal files.
> Better checkpoint mechanism
> ---------------------------
>
> Key: BOOKKEEPER-564
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-564
> Project: Bookkeeper
> Issue Type: Improvement
> Components: bookkeeper-server
> Reporter: Sijie Guo
> Assignee: Sijie Guo
> Fix For: 4.3.0
>
> Attachments: 0001-BOOKKEEPER-564-Better-checkpoint-mechanism.patch,
> 0001-BOOKKEEPER-564-Better-checkpoint-mechanism.patch,
> 0002-BOOKKEEPER-564-Better-checkpoint-mechanism.patch, BOOKKEEPER-564.patch,
> BOOKKEEPER-564.patch
>
>
> Currently, SyncThread made a checkpoint too frequently, which affects
> performance. data is writing to entry logger file might be blocked by syncing
> same entry logger file, which affect bookie to achieve higher throughput. We
> could schedule checkpoint only when rotating an entry log file. so new
> incoming entries would be written to newer entry log file and old entry log
> file could be synced.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
