[
https://issues.apache.org/jira/browse/BOOKKEEPER-564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13626410#comment-13626410
]
Ivan Kelly commented on BOOKKEEPER-564:
---------------------------------------
The more I look at it, the less I like this Checkpointer interface. It's doing
exactly the type of thing I was trying to get rid of with BOOKKEEPER-572
originally. Specifically, the ledger storage is reaching around to make a call
on itself through this interface (SafeEntryLogAdder does this, and it's nasty).
The motivation for this interface is to allow the ledger storage itself to
control when it makes a checkpoint/flush. As I said in a previous comment we
can remove the sync thread and move the logic into the ledger storage directly.
I'm trying this now, should have a patch later.
{quote}
separate #flush and #checkpoint would make interface clearly rather than mixing
things in #shutdown method.
{quote}
They can be removed from the interface completely if we allow ledger storage to
handle its own flushing.
> Better checkpoint mechanism
> ---------------------------
>
> Key: BOOKKEEPER-564
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-564
> Project: Bookkeeper
> Issue Type: Improvement
> Components: bookkeeper-server
> Reporter: Sijie Guo
> Assignee: Sijie Guo
> Fix For: 4.3.0
>
> Attachments: 0002-BOOKKEEPER-564-Better-checkpoint-mechanism.patch,
> BOOKKEEPER-564.patch, BOOKKEEPER-564.patch
>
>
> Currently, SyncThread made a checkpoint too frequently, which affects
> performance. data is writing to entry logger file might be blocked by syncing
> same entry logger file, which affect bookie to achieve higher throughput. We
> could schedule checkpoint only when rotating an entry log file. so new
> incoming entries would be written to newer entry log file and old entry log
> file could be synced.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
