[ 
https://issues.apache.org/jira/browse/BOOKKEEPER-613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13686227#comment-13686227
 ] 

Sijie Guo commented on BOOKKEEPER-613:
--------------------------------------

one question, if you are adding a total different ledger storage, it makes 
sense to put the interleaved ledger storage into a sub package. but since the 
skip list ledger storage is based on interleaved ledger storage, I don't see 
the value of doing this refactor now. I would hold on this refactor until we 
need it. since we had bunch of patches is based on current package structure, I 
would suggest getting them merged first before we doing this refactor, 
otherwise it is quite painful for us to contribute. 
                
> Prep codebase for new ledger storage
> ------------------------------------
>
>                 Key: BOOKKEEPER-613
>                 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-613
>             Project: Bookkeeper
>          Issue Type: Sub-task
>          Components: bookkeeper-server
>            Reporter: Ivan Kelly
>            Assignee: Ivan Kelly
>             Fix For: 4.3.0
>
>         Attachments: 
> 0001-BOOKKEEPER-613-Prep-codebase-for-new-ledger-storage.patch
>
>
> Currently all the code for interleaved ledger storage is in the bookie 
> package. Likewise, the tests are in the bookie package. This makes it unclear 
> what is a test of the ledger storage and what is a test of the bookie in 
> general.
> This JIRA is to move both of these into a subpackage of bookie, 
> o.a.b.bookie.ills. BOOKKEEPER-432 will then go into o.a.b.bookie.sls, and 
> each of the tests in the ills package will have a corresponding test in sls.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to